[patch] Drop an unnecessary use of writev
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 16 15:04:21 PST 2015
r255837. Thanks!
Cheers,
Rafael
On 16 December 2015 at 16:55, Davide Italiano <davide at freebsd.org> wrote:
> On Wed, Dec 16, 2015 at 7:27 AM, Rafael EspĂndola
> <rafael.espindola at gmail.com> wrote:
>> I think the code this patch deletes is based on a misunderstanding of
>> what guarantees writev provides. In particular, writev with 1 iovec is
>> not "more atomic" than a write.
>>
>> With the attached test program I get 'a's and 'b's on the same line on
>> OS X when using both write and writev.
>
>
> Just tested and it's the same on FreeBSD. I'm for shipping this.
>
> Thanks,
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
More information about the llvm-commits
mailing list