[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 13:51:31 PST 2015


tejohnson updated this revision to Diff 43060.
tejohnson added a comment.

- Rebase and address Rafael's review comments.

  I think I have addressed all your comments. Notable changes from prior version:
- Use gold's symbol resolution via IRMover, and invoke renameModuleForThinLTO afterwards to do renaming (with TODO noting that this is temporary until we can do this in place)
- Rebase to use new RAII wrapper for plugin file handling. Add move assignment/copy constructor to enable moving ownership into TaskInfo object. Change RAII PluginInputFile wrapper to use a unique_ptr for the ld_plugin_input_file object so that it can be moved, and add a flag to prevent double-release on a moved object.
- s/Thread/Task/
- Add test to ensure gold's symbol resolution not overridden.
- Add test for plugin option obj-path handling with ThinLTO threads


http://reviews.llvm.org/D15390

Files:
  include/llvm/Support/thread.h
  test/tools/gold/X86/pr19901_thinlto.ll
  test/tools/gold/X86/thinlto.ll
  tools/gold/gold-plugin.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15390.43060.patch
Type: text/x-patch
Size: 21440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151216/b693f3b8/attachment.bin>


More information about the llvm-commits mailing list