[PATCH] D15549: [X86] Use push-pop for materializing small constants under 'minsize'

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 11:02:35 PST 2015


hans added a comment.

In http://reviews.llvm.org/D15549#311671, @majnemer wrote:

> I believe this is a violation of the x64 ABI because your program has stack pointer adjustments after the prologue without also having a frame pointer.


Thanks for pointing this out. Sounds like we should avoid the push/pop lowering for Win64 in functions without frame pointers, then.


http://reviews.llvm.org/D15549





More information about the llvm-commits mailing list