[PATCH] D14902: [AArch64] Promote loads from stored

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM, but please rename 'stored' to 'store' as suggested in the comments.  I didn't enumerate all cases, so you might want to perform a mass replace.

I also assume you'd done extensive correctness testing.  IIRC, you didn't see any major performance improvements/regressions.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:46
@@ -45,2 +45,3 @@
 STATISTIC(NumZeroStoresPromoted, "Number of narrow zero stores promoted");
+STATISTIC(NumLoadsFromStoredPromoted, "Number of loads from stored promoted");
 
----------------
s/stored/stores

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:98
@@ +97,3 @@
+
+  // Scan the instructions looking for a store that writes to the address
+  // from which the current load instruction reads.
----------------
Maximize 80-column.

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:102
@@ +101,3 @@
+  bool findMatchingStore(MachineBasicBlock::iterator I, unsigned Limit,
+                         MachineBasicBlock::iterator &Stored);
+
----------------
s/Stored/Store

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:864
@@ -802,1 +863,3 @@
 
+MachineBasicBlock::iterator AArch64LoadStoreOpt::promoteLoadFromStored(
+    MachineBasicBlock::iterator LoadInst,
----------------
s/Stored/Store


http://reviews.llvm.org/D14902