[PATCH] D15510: [Polly] Unique value read accesses

[Tobias Grosser via llvm-commits]

grosser added a comment.

This looks generally good to me (besides some minor comments), but let's wait for the phone call tonight.


================
Comment at: include/polly/ScopInfo.h:833
@@ -831,1 +832,3 @@
 
+  /// @brief The set of values defined elsewehere required in this ScopStmt and
+  ///        their MK_Value READ MemoryAccesses.
----------------
elsewhere

================
Comment at: include/polly/ScopInfo.h:1000
@@ +999,3 @@
+  /// @brief Return the MemoryAccess that reloads a value, or nullptr if not
+  ///        (yet) added.
+  MemoryAccess *lookupValueReadOf(Value *Inst) const {
----------------
... or unexisting.

================
Comment at: include/polly/ScopInfo.h:1935
@@ -1923,2 +1934,3 @@
 
-  /// @brief Create a MemoryAccess for reloading an llvm::Value.
+  /// @brief Ensure an llvm::Value is available in the BB's statment, creating a
+  ///        MemoryAccess for reloading it if necessary.
----------------
statement

================
Comment at: include/polly/ScopInfo.h:1942
@@ -1945,3 +1941,3 @@
   /// @see ScopArrayInfo::MemoryKind
-  void addValueReadAccess(Value *Value, PHINode *User, BasicBlock *UserBB);
+  void ensureValueReload(Value *Value, BasicBlock *UserBB);
 
----------------
I would prefer to call this ensureValueRead() as this corresponds better with the surrounding code (the map is called ValueReads).


http://reviews.llvm.org/D15510