[PATCH] D15542: AMDGPU: Fix off-by-one in SIRegisterInfo::eliminateFrameIndex

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 07:11:28 PST 2015


tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.h:444-445
@@ -443,4 +443,4 @@
 
-  void insertNOPs(MachineBasicBlock::iterator MI, int Count) const;
+  void insertNOPWaits(MachineBasicBlock::iterator MI, int Count) const;
 
   /// \brief Returns the operand named \p Op.  If \p MI does not have an
----------------
To me this is still confusing.  I would probably go a step further and re-name the function insertWaitStates().  

Otherwise, LGTM.


http://reviews.llvm.org/D15542





More information about the llvm-commits mailing list