[PATCH] D15553: PR25717: fatal IO error writing large outputs to console on Windows

[Aaron Ballman via llvm-commits]

aaron.ballman added inline comments.

================
Comment at: lib/Support/raw_ostream.cpp:570
@@ -569,1 +569,3 @@
 
+#ifndef LLVM_ON_WIN32
+  bool ShouldWriteInChunks = false;
----------------
Is there a noticeable regression in performance due to this chunking? If so, I would prefer if this were dynamically set based on the Windows version. Microsoft is pretty aggressively upgrading people to Windows 10, so it would be good not to punish all Windows users if the performance hit is measurable.


http://reviews.llvm.org/D15553