[llvm] r254592 - Fix class SCEVPredicate has virtual functions and accessible non-virtual destructor.

[Andy Gibbs via llvm-commits]

On Thursday, December 03, 2015 8:15 PM, David Blaikie wrote:
> Sure sure, no rush.

I didn't forget, but its been a busy couple of weeks and I didn't have a 
chance to look into this again until today.  I have made a patch to revert 
the change and to the CMake files to remove (actually not enable) the 
warning for gcc.  However, I have done a little playing around to find the 
limits of the clang diagnostic and it doesn't correctly identify the 
non-virtual dtor inside a friend function.  I've stuck a bug-report up here: 
https://llvm.org/bugs/show_bug.cgi?id=25850

I'd like to see how that pans out before making this change.  I hope that's 
ok?  :o)

Cheers
Andy