[compiler-rt] r255735 - [cfi] Exclude ubsan runtime library from non-diag CFI builds.

[Peter Collingbourne via llvm-commits]

Okay, but that shouldn't mean that we should do the wrong thing first of all.
Let's first make sure we are confident we can't do this without shipping
yet another runtime library.

Peter

On Tue, Dec 15, 2015 at 06:03:58PM -0800, Evgenii Stepanov wrote:
> I don't have a clear understanding of how that refactoring would work,
> particularly with the initialization order of cfi vs ubsan.
> 
> On Tue, Dec 15, 2015 at 5:12 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> > On Wed, Dec 16, 2015 at 12:38:41AM -0000, Evgeniy Stepanov via llvm-commits wrote:
> >> Author: eugenis
> >> Date: Tue Dec 15 18:38:41 2015
> >> New Revision: 255735
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=255735&view=rev
> >> Log:
> >> [cfi] Exclude ubsan runtime library from non-diag CFI builds.
> >>
> >> Split the CFI runtime in two: cfi and cfi_diag. The latter includes
> >> UBSan runtime to allow printing diagnostics.
> >
> > Huh, was this needed in order to fix build breakage? I thought we were going to
> > resolve this with a refactoring.
> > http://reviews.llvm.org/D15358#inline-126977
> >
> > Thanks,
> > --
> > Peter
> 

-- 
Peter