[PATCH] D15538: [WebAssembly] Implement instruction selection for constant offsets in addresses.

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 14:06:31 PST 2015


sunfish marked an inline comment as done.

================
Comment at: test/CodeGen/WebAssembly/offset.ll:1
@@ +1,2 @@
+; RUN: llc < %s -asm-verbose=false | FileCheck %s
+
----------------
dschuff wrote:
> I guess we don't need complete coverage of every new case in the tbglen (or do we?) but we should probably also have at least one or two of extload , zextload, sextload, truncstore too.
I'll add more coverage when I fix the getelementptr issue and we can have more realistic testcases and not just inttoptr/ptrtoint. You're right though that it's good to have some coverage of the extending loads and truncating stores now; I added those now.


Repository:
  rL LLVM

http://reviews.llvm.org/D15538





More information about the llvm-commits mailing list