[PATCH] D15494: [ELF] - implemented @indntpoff (x86) relocation and its optimization.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:225
@@ -224,3 +224,3 @@
     P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
-                        Target->getTlsGotReloc(), Config->Mips64EL);
+                        Target->getTlsGotReloc(-1), Config->Mips64EL);
     P->r_offset = Out<ELFT>::Got->getEntryAddr(*Body);
----------------
Oh this is worse than before. I didn't expect that you had to use a magic number instead of a default parameter. Default parameter is better.


http://reviews.llvm.org/D15494