[Compiler-rt] Fix compile of /lib/profile with MSVC

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 09:56:17 PST 2015


Sorry, I meant 'Not needed for this patch'.

On Tue, Dec 15, 2015 at 9:55 AM, Xinliang David Li <davidxl at google.com> wrote:
> Probably need for this patch. To get parity with Support/Compiler.h,
> we need to introduce a lot more supporting macros such as has_feature,
> ....
>
> David
>
> On Tue, Dec 15, 2015 at 9:25 AM, Vedant Kumar <vsk at apple.com> wrote:
>> Hi Johan,
>>
>> Your definition of LLVM_LIBRARY_VISIBILITY is different from the one in include/llvm/Support/Compiler.h.
>>
>> Do you think the on in llvm should be updated?
>>
>> vedant
>>
>>> On Dec 14, 2015, at 3:33 PM, Johan Engelen via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>>
>>> Hello David,
>>>   As promised, here are the patches to fix building of compiler-rt's lib/profile with MSVC.
>>>
>>> I have included a patch for release_37 branch, in case there is a chance for it to be applied there too.
>>>
>>> cheers,
>>>   Johan
>>>
>>>
>>> <RELEASE37_profile_fixMSVCbuild.patch><TRUNK_profile_fixMSVCbuild.patch>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>


More information about the llvm-commits mailing list