[PATCH] D15521: [mips] Range check uimm20 and fixed a bug this revealed.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 04:19:46 PST 2015


dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: llvm-commits.
Herald added a subscriber: dsanders.

The bug was that dextu's operand 3 would print 0-31 instead of 32-63 when
printing assembly. This came up when replacing
MipsInstPrinter::printUnsignedImm() with a version that could handle arbitrary
bit widths.

MipsAsmPrinter::printUnsignedImm*() don't seem to be used so they have been
removed.

http://reviews.llvm.org/D15521

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/InstPrinter/MipsInstPrinter.cpp
  lib/Target/Mips/InstPrinter/MipsInstPrinter.h
  lib/Target/Mips/MicroMipsInstrInfo.td
  lib/Target/Mips/Mips64InstrInfo.td
  lib/Target/Mips/MipsAsmPrinter.cpp
  lib/Target/Mips/MipsAsmPrinter.h
  lib/Target/Mips/MipsInstrInfo.td
  lib/Target/Mips/MipsMSAInstrInfo.td
  test/MC/Disassembler/Mips/micromips64r6/valid.txt
  test/MC/Mips/micromips/invalid-wrong-error.s
  test/MC/Mips/mips-control-instructions.s
  test/MC/Mips/mips1/valid.s
  test/MC/Mips/mips2/valid.s
  test/MC/Mips/mips3/valid.s
  test/MC/Mips/mips32/valid.s
  test/MC/Mips/mips32r2/invalid.s
  test/MC/Mips/mips32r2/valid.s
  test/MC/Mips/mips32r3/valid.s
  test/MC/Mips/mips32r5/valid.s
  test/MC/Mips/mips32r6/valid.s
  test/MC/Mips/mips4/valid.s
  test/MC/Mips/mips5/valid.s
  test/MC/Mips/mips64/valid.s
  test/MC/Mips/mips64extins.ll
  test/MC/Mips/mips64r2/valid.s
  test/MC/Mips/mips64r3/valid.s
  test/MC/Mips/mips64r5/valid.s
  test/MC/Mips/mips64r6/valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15521.42833.patch
Type: text/x-patch
Size: 30333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151215/13086109/attachment.bin>


More information about the llvm-commits mailing list