[PATCH] D15405: [EHPersonality] Add a new personality enum to represent langindPad of token type

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 14:11:36 PST 2015


rnk added a comment.

In http://reviews.llvm.org/D15405#310289, @JosephTremoulet wrote:

> It just seemed backwards to snoop the landingpad's type when we expect landingpad type to be dictated by the personality, nothing deeper than that.


I think it's fine. landingpad personalities don't impose a lot of constraints on the compiler. It seems nicer to treat them as more of an open set of well-behaved things.

> That's an interesting point.  I do still wonder, if we were inventing landingpad over again today, whether we'd just always give it token type (though again, even if that seems the most sensible I don't think we need to switch to that right now).


I guess if I were designing landingpad from scratch around a language with relocating GC, then yeah, I'd probably make it always use token type, and always use intrinsics to extract the values instead of `extractvalue`.


http://reviews.llvm.org/D15405





More information about the llvm-commits mailing list