[llvm] r255546 - Print the eh_frame section in MachoDump.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 14:05:42 PST 2015


> --- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
> +++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Mon Dec 14 15:39:27 2015

Why MachO dump? ELF uses the same format.


> +    assert(EntryEndPos <= End &&
> +           "__eh_frame entry length exceeds section size");

Please use report_fatal_error or similar. Asserts should really be for
things that cannot happen.

> -      outs() << "llvm-objdump: warning: unhandled __eh_frame section\n";

An error would probably be better.

Cheers,
Rafael


More information about the llvm-commits mailing list