[PATCH] D15405: [EHPersonality] Add a new personality enum to represent langindPad of token type

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 13:57:19 PST 2015


JosephTremoulet added a comment.

In http://reviews.llvm.org/D15405#310252, @rnk wrote:

> Joseph, what did you think was wrong with checking for token type? I think the original approach is simpler. It's a little funky when you have to materialize `resume {i8*, i32}` from separate values, but oh well.


It just seemed backwards to snoop the landingpad's type when we expect landingpad type to be dictated by the personality, nothing deeper than that.

> I can imagine wanting to use some kind of relocating GC scheme in a function that uses C++ EH, and needing to name out the right __gxx_personality* symbol for the platform.


That's an interesting point.  I do still wonder, if we were inventing landingpad over again today, whether we'd just always give it token type (though again, even if that seems the most sensible I don't think we need to switch to that right now).


http://reviews.llvm.org/D15405





More information about the llvm-commits mailing list