[PATCH] D15471: [IR] Add support for floating pointer and vector atomic loads and stores

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 12:58:17 PST 2015


reames added a comment.

In http://reviews.llvm.org/D15471#309318, @jfb wrote:

> Does this have any implications for alias analysis, especially type-based? The C++ model means memory locations are always atomic, so this isn't un-aliasing non-atomics further, but does LLVM's AAs understand that atomics can be non-integral now?


I'm not sure what you're trying to ask here specifically, but I have no reason to believe this influences AA in any way.  Any AA which is using the *llvm type* to prove no alias is wrong and should be fixed.  TBAA is entirely orthogonal and uneffected.

> As explained in one of my comments, I think this patch should only do FP and not vectors.


I'm okay with this for moment.  Will upload a simplified patch shortly.


http://reviews.llvm.org/D15471





More information about the llvm-commits mailing list