[PATCH] D15489: Use getEdgeProbability() instead of getEdgeWeight() in BFI and remove getEdgeWeight() interfaces from MBPI.

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 12:21:53 PST 2015


davidxl added inline comments.

================
Comment at: include/llvm/Analysis/BlockFrequencyInfoImpl.h:1193
@@ -1194,3 +1192,3 @@
       if (!addToDist(Dist, OuterLoop, Node, getNode(*SI),
-                     BPI->getEdgeWeight(BB, SI)))
+                     BPI->getEdgeProbability(BB, SI).getNumerator()))
         // Irreducible backedge.
----------------
Can you add a file local wrapper function in this file 

inline static  uint32_t getEdgeWeight(... ) { return ... getNumerator()...)



================
Comment at: test/Analysis/BlockFrequencyInfo/bad_input.ll:13
@@ -14,1 +12,3 @@
+; Check that we get 1 and a huge frequency instead of 0,3.
+; CHECK-NEXT: for.body: float = 2147483647.8,
 for.body:
----------------
What makes this diff?


http://reviews.llvm.org/D15489





More information about the llvm-commits mailing list