[PATCH] D15504: Bug fix for shrink-wrap

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 12:09:30 PST 2015


> On Dec 14, 2015, at 11:59 AM, Weiming Zhao <weimingz at codeaurora.org> wrote:
> 
> weimingz added a comment.
> 
> This patch is more of a workaround to fix a bug. It seems to me the conditions of the safe point is not strong enough.

I agree, but the fix seems too narrow, that’s why I would like a test case to make sure that whatever we come up with fixes it.


> Since it's not SSA, the dominance relationship can't guarantee that the save point is before the def.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D15504
> 
> 
> 



More information about the llvm-commits mailing list