[PATCH] D15230: [BranchFolding] Merge MMOs during tail merge

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 10:48:00 PST 2015


gberry added a reviewer: hfinkel.
gberry added a subscriber: hfinkel.

================
Comment at: include/llvm/CodeGen/MachineInstr.h:350
@@ -349,2 +349,3 @@
   bool memoperands_empty() const { return NumMemRefs == 0; }
+  uint8_t getNumMemOperands() const { return NumMemRefs; }
 
----------------
I don't think you want to have the uint8_t implementation detail leak out of the interface here.  Perhaps this should be 'unsigned'?
I'd like to hear from @hfinkel on this detail before I can approve it.


http://reviews.llvm.org/D15230





More information about the llvm-commits mailing list