[PATCH] D15212: [PGO] Value profiling text format reader/writer support

[Vedant Kumar via llvm-commits]

vsk added a comment.

Thanks, lgtm with two minor changes.


================
Comment at: lib/ProfileData/InstrProfReader.cpp:112
@@ -111,1 +111,3 @@
 
+#define CHECK_LINE_END(Line)                                                   \
+  if (Line.is_at_end())                                                        \
----------------
Could you move these inside `readValueProfileData` and `#undef` them at the end of the function?

================
Comment at: lib/ProfileData/InstrProfReader.cpp:113
@@ +112,3 @@
+#define CHECK_LINE_END(Line)                                                   \
+  if (Line.is_at_end())                                                        \
+    return error(instrprof_error::truncated);
----------------
These macro function arguments should be wrapped in parens.


http://reviews.llvm.org/D15212