[PATCH] D14070: [FPEnv Core 05/14] Teach IR builder and folders about new flags

[Sergey Dmitrouk via llvm-commits]

sdmitrouk added inline comments.

================
Comment at: test/Other/fpenv-constant-fold.ll:10
@@ +9,3 @@
+; CHECK-LABEL: @do-not-fold-fadd-that-can-trap
+; CHECK: fadd {{.*}} 1.000000e+308, {{.*}} 1.000000e+308
+entry:
----------------
joker.eph wrote:
> Nit: the second `{{.*}}` seems spurious.
> 
> Also do you expect the `nrnd` to be dropped?
> Nit: the second {{.*}} seems spurious.

Right, thanks.

> Also do you expect the nrnd to be dropped?

No. Initially I wanted to check only for presence of floating-point instructions, but then added arguments as was requested, now changed to check everything.


Repository:
  rL LLVM

http://reviews.llvm.org/D14070