[PATCH] D15464: Add a C++11 ThreadPool implementation in LLVM

[David Blaikie via llvm-commits]

On Sun, Dec 13, 2015 at 4:39 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:

>
> On Dec 13, 2015, at 4:30 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
>
> On Sat, Dec 12, 2015 at 2:58 PM, Mehdi AMINI via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> joker.eph closed this revision.
>> joker.eph marked 2 inline comments as done.
>> joker.eph added a comment.
>>
>> r255444
>>
>>
>> ================
>> Comment at: lib/Support/ThreadPool.cpp:139
>> @@ +138,3 @@
>> +ThreadPool::~ThreadPool() {
>> +  EnableFlag = false;
>> +  wait();
>> ----------------
>> tejohnson wrote:
>> > Is this just for completeness? It doesn't look like this flag is used
>> when ! LLVM_ENABLE_THREADS.
>> It is to silent a compiler warning about "member variable not used" when
>> compiling with LLVM_ENABLE_THREAD=OFF
>>
>
> Perhaps a more explicit cast to void, or ifdef out the variable instead?
>
>
> I tried to keep the header clean of ifdef,
>

Any particular reason? Seems somewhat suitable for a header creating
threading abstractions to have some ifdefs depending on whether threading
is enabled at all.


> I can go with a (void) use instead.
>
>
> —
> Mehdi
>
>
>
>
>>
>>
>> http://reviews.llvm.org/D15464
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151213/2e76bcf2/attachment.html>