[PATCH] D15405: [EHPersonality] Add a new personality enum to represent langindPad of token type

[Chen Li via llvm-commits]

chenli added a comment.

> If you don't like adding your runtime's personality to the enum, perhaps we should go back to Chen's original suggestion of just checking the type of the landingpad in SelectionDAG.  The reason we started going in this direction instead was "It seems a little backwards to check the landingpad's type as the first check, since the personality dictates the landingpad's type".  But maybe it makes sense to allow that much variation within Unknown, since it is after all a bucket for "all the other personalities" -- if we wanted to be pedantic, SelectionDAG could allow either token or struct for Unknown, but require struct for all the known personalities that use landingpads.


I dont think we mind adding our own runtime's personality, but I just don't know if that's necessary. Personally, I'd still prefer to have a generic enum. Maybe having a Unknown_With_Token_Type and make it similar to Unknown is the best choice for now? I don't think we need to care about isNoOpWithoutInvoke downstream since our current personality is Unknown anyway.


http://reviews.llvm.org/D15405