[PATCH] D15453: [ELF] - refactor of code in RelocationSection<ELFT>::writeTo()
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 11 08:14:28 PST 2015
grimar created this revision.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
Just a little reformat of conditions.
http://reviews.llvm.org/D15453
Files:
ELF/OutputSections.cpp
Index: ELF/OutputSections.cpp
===================================================================
--- ELF/OutputSections.cpp
+++ ELF/OutputSections.cpp
@@ -264,21 +264,19 @@
bool LazyReloc = Body && Target->supportsLazyRelocations() &&
Target->relocNeedsPlt(Type, *Body);
- if (CanBePreempted) {
- unsigned GotReloc =
- Body->isTLS() ? Target->getTlsGotReloc() : Target->getGotReloc();
- if (NeedsGot)
- P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
- LazyReloc ? Target->getPltReloc() : GotReloc,
- Config->Mips64EL);
- else
- P->setSymbolAndType(Body->getDynamicSymbolTableIndex(),
- NeedsCopy ? Target->getCopyReloc()
- : Target->getDynReloc(Type),
- Config->Mips64EL);
- } else {
- P->setSymbolAndType(0, Target->getRelativeReloc(), Config->Mips64EL);
- }
+ unsigned Sym = CanBePreempted ? Body->getDynamicSymbolTableIndex() : 0;
+ unsigned Rel;
+ if (!CanBePreempted)
+ Rel = Target->getRelativeReloc();
+ else if (LazyReloc)
+ Rel = Target->getPltReloc();
+ else if (NeedsGot)
+ Rel = Body->isTLS() ? Target->getTlsGotReloc() : Target->getGotReloc();
+ else if (NeedsCopy)
+ Rel = Target->getCopyReloc();
+ else
+ Rel = Target->getDynReloc(Type);
+ P->setSymbolAndType(Sym, Rel, Config->Mips64EL);
if (NeedsGot) {
if (LazyReloc)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15453.42526.patch
Type: text/x-patch
Size: 1534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151211/da02c909/attachment.bin>
More information about the llvm-commits
mailing list