[PATCH] D15243: [PGO]: Do not use invalid Char in instrumentation variable names
Xinliang David Li via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 10 20:07:03 PST 2015
Very well. I had just added a test case to cover version 3. Will add
another one in this patch to cover the new naming scheme.
thanks,
David
On Thu, Dec 10, 2015 at 7:30 PM, Sean Silva <chisophugis at gmail.com> wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15243#307935, @davidxl wrote:
>
>> I will post test changes in a different patch -- existing tests already cover the case.
>
>
> No. This patch changes functionality and needs a test.
>
>
> http://reviews.llvm.org/D15243
>
>
>
More information about the llvm-commits
mailing list