[PATCH] D15289: Avoid inlining CallSites leading to unreachable

[David Majnemer via llvm-commits]

I don't recall seeing any data collection with regard to the threshold.

On Thursday, December 10, 2015, hfinkel at anl.gov <hfinkel at anl.gov> wrote:

> hfinkel added a comment.
>
> In http://reviews.llvm.org/D15289#307628, @junbuml wrote:
>
> > > Note on windows "main" may be "wmain" "WinMain" "WINMAIN" "MAIN"
> "AfxWinMain" "ENTGQQ" etc.
> >
> >
> >
>
>
> ...
>
> > I agree using BPI with some general heuristic here and enhancing BPI
> itself must be a right approach in general. But, I prefer to take
> incremental changes as long as the basic idea and direction is reasonable.
>
>
> This is why I'm not super happy about this patch: Aside for the test
> cases, it is not clear this is really any kind of incremental step toward
> the solution we want (based on BPI). I'm not unhappy enough to say it
> shouldn't go in if others are okay with it going in, but I agree that the
> BPI-based solution is really where we should be devoting our efforts.
>
> >   ...
>
>
>
> http://reviews.llvm.org/D15289
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151210/3c6a8c29/attachment.html>