[PATCH] D11438: Part 2 to fix x86_64 fp128 calling convention.

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 11:32:53 PST 2015


davidxl added inline comments.

================
Comment at: test/CodeGen/X86/fp128-cast.ll:154
@@ +153,3 @@
+
+define fp128 @TestPair128(i64 %a, i64 %b) {
+entry:
----------------
Please move this test case to a different patch.

================
Comment at: test/CodeGen/X86/fp128-compare.ll:4
@@ +3,3 @@
+
+define i32 @TestComp32GT(float %d1, float %d2) {
+entry:
----------------
Move this test case out of the patch -- -there are more than 20 or so test cases below that need to be separated out.


http://reviews.llvm.org/D11438





More information about the llvm-commits mailing list