davidxl added a comment. LGTM. As Justin says, please continue the clean up effort: 1) unify the profile summary data for PGO and Sample FDO 2) move the cold attribute logic to LLVM Repository: rL LLVM http://reviews.llvm.org/D15245