[PATCH] D15118: [InstCombine] Make MatchBSwap also match bit reversals

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 05:31:03 PST 2015


sbaranga added a subscriber: sbaranga.
sbaranga added a comment.

Hi James,

I had a look over this and the logic seems sound to me. I only have one (superficial) complaint: the old commets in CollectBSwapBitReverseParts refer only about bswap. Maybe we can rename it to something like CollectBitParts (since we're basically only tracking bits now and have the bswap/bitreverse validation somewhere else).

Cheers,
Silviu


Repository:
  rL LLVM

http://reviews.llvm.org/D15118





More information about the llvm-commits mailing list