[PATCH] D15307: [Polly] ScopInfo: Harmonize the different ARRAY_KINDs

[Michael Kruse via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Don't you want to wait for a third opinion?


================
Comment at: include/polly/ScopInfo.h:144
@@ +143,3 @@
+    /// corresponding READ is added. For instrance, the use/def chain of a
+    /// llvm::Value %V depicted below
+    ///              ______________________
----------------
llvm::Value %V **is** depicted below

================
Comment at: include/polly/ScopInfo.h:174
@@ +173,3 @@
+    /// ------------------------------------
+    /// ------------------------------------
+    ///
----------------
Something seems to have gone wrong after clang-format

================
Comment at: include/polly/ScopInfo.h:218
@@ +217,3 @@
+    /// used. The modeling used is identical to MK_PHI, with the exception
+    /// that there are no READ from these memory objects. The PHINode's
+    /// llvm::Value is treated as a value escaping the SCoP. WRITE accesses
----------------
READ**s**

================
Comment at: include/polly/ScopInfo.h:699
@@ -676,3 +698,3 @@
   /// @brief Whether this is an access of an explicit load or store in the IR.
-  bool isExplicit() const { return Origin == EXPLICIT; }
+  bool isArrayKind() const { return Kind == ScopArrayInfo::MK_Array; }
 
----------------
Me neither; Code completion in Visual Studio will suggest isXXXKind when typing isKind.


http://reviews.llvm.org/D15307