[PATCH] D15391: [LazyValueInfo] Reduce memory usage

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 02:21:17 PST 2015


hfinkel added a subscriber: hfinkel.
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:368
@@ -362,4 +367,3 @@
       SeenBlocks.insert(BB);
-      lookup(Val)[BB] = Result;
       if (Result.isOverdefined())
         OverDefinedCache[BB].insert(Val);
----------------
We should add a comment somewhere, maybe here, explaining that we insert overdefined values into their own cache to reduce memory overhead.


http://reviews.llvm.org/D15391





More information about the llvm-commits mailing list