[PATCH] D15315: [X86ISelLowering] Replace uint64_t with APInt to prevent overflow

Chen Li via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 23:54:43 PST 2015


chenli added a comment.

I applied the patch locally and it worked with 0xFFFFFFFF. However, in practice, neither 0xFFFFFFFF nor 0 will flow into this function because llvm handles them with special cases. For 0, it returns a 0 directly, and for 0xFFFFFFFF, it returns 0 - (the other operand). I've hacked to bypass the special cases in order to test the overflow case could be handled correctly by this code.


http://reviews.llvm.org/D15315





More information about the llvm-commits mailing list