[llvm] r255158 - [PGO] Rename the profdata filename to avoid the conflict b/w tests.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 19:30:08 PST 2015


Using `%t` should avoid this I think.

In fact, using %T is extremely rare in LLVM tests. I would recommend
migrating all tests to using %t instead.

On Wed, Dec 9, 2015 at 1:27 PM, Rong Xu via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: xur
> Date: Wed Dec  9 15:27:59 2015
> New Revision: 255158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255158&view=rev
> Log:
> [PGO] Rename the profdata filename to avoid the conflict b/w tests.
>
> Two tests diag_mismatch.ll and diag_no_funcprofdata.ll generates the same
> profdata filename which can conflict in current test runs. This patch
> renames them to have different names.
>
> Modified:
>     llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll
>
> Modified: llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll?rev=255158&r1=255157&r2=255158&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll
> (original)
> +++ llvm/trunk/test/Transforms/PGOProfile/diag_no_funcprofdata.ll Wed Dec
> 9 15:27:59 2015
> @@ -1,5 +1,5 @@
> -; RUN: llvm-profdata merge %S/Inputs/diag.proftext -o %T/diag.profdata
> -; RUN: opt < %s -pgo-instr-use -pgo-test-profile-file=%T/diag.profdata -S
> 2>&1 | FileCheck %s
> +; RUN: llvm-profdata merge %S/Inputs/diag.proftext -o %T/diag2.profdata
> +; RUN: opt < %s -pgo-instr-use -pgo-test-profile-file=%T/diag2.profdata
> -S 2>&1 | FileCheck %s
>
>  ; CHECK: No profile data available for function bar
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151209/958a3ca6/attachment.html>


More information about the llvm-commits mailing list