[PATCH] D15308: [tsan] Support aarch64 for Android.

Yabin Cui via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 15:50:32 PST 2015


yabinc added inline comments.

================
Comment at: lib/tsan/rtl/tsan_platform.h:129
@@ +128,3 @@
+
+#else
+
----------------
eugenis wrote:
> Is there a reason you are not using the generic aarch64/linux mappings below?
> For ASan/aarch64/android, I've noticed that ART requires a first 4GB mapping, which seems incompatible with this layout.
> 
The Android mapping is different from Mapping39 in kLoAppMemBeg-kLoAppMemEnd. Because
android links all executables as shared libraries.
Thanks for reminding. I didn't notice that. I will check it out after my vacation.


http://reviews.llvm.org/D15308





More information about the llvm-commits mailing list