[PATCH] D15296: [tsan] Use internal_sigfillset to replace REAL(sigfillset).
Yabin Cui via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 15:47:02 PST 2015
yabinc added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:621-624
@@ -620,6 +620,2 @@
-void internal_sigfillset(__sanitizer_sigset_t *set) {
- internal_memset(set, 0xff, sizeof(*set));
-}
-
#if SANITIZER_LINUX
----------------
kubabrecka wrote:
> Why do you need to move the implementation to sanitizer_posix.cc? `internal_sigfillset` is defined in both `sanitizer_linux.cc` and `sanitizer_mac.cc` already, so you shouldn't need to move it.
Sorry, I didn't notice the implementation in sanitizer_mac.cc.
http://reviews.llvm.org/D15296
More information about the llvm-commits
mailing list