[PATCH] D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part).

Yury Gribov via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 15:17:09 PST 2015


ygribov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_flags.inc:197
@@ +196,2 @@
+            "Deduplicate multiple reports for single source location in "
+            "halt_on_error=false mode.")
----------------
samsonov wrote:
> kcc wrote:
> > ygribov wrote:
> > > kcc wrote:
> > > > add "(asan only)" to the descr string
> > > Do we want to enable this for UBSan as well btw?
> > It hasn't been a problem for us in the past.
> > Besides, ubsan has a mode with no runtime, so this flag will not work there. 
> > But if you think we need it there, sure, why not. 
> > (The code will need to be moved to sanitizer_common then)
> UBSan already has a somewhat robust deduplication based on source locations.
Yeah, I meant a flag to disable those.


http://reviews.llvm.org/D15080





More information about the llvm-commits mailing list