[PATCH] D15340: Separate CSRs into a subset handled via explicit copies and a subset handled by prologue/epilogue

[hfinkel@anl.gov via llvm-commits]

hfinkel added a comment.

Sounds good.

> Yes, as implemented in clang front end (specified by Itanium ABI, we will have a one-time initialization block that can be slow).


Are the Clang parts upstream yet? (or are you waiting on this part first?)


================
Comment at: include/llvm/Target/TargetLowering.h:2270
@@ +2269,3 @@
+
+  virtual void handleSplitCSR(MachineBasicBlock *Entry,
+                              MachineBasicBlock *Exit) const {
----------------
We need more comments here explaining what exactly this function is supposed to do, at what stage in the pipeline it is called, etc.


http://reviews.llvm.org/D15340