[PATCH] D15334: PC-relative support for EmitValue
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 11:28:35 PST 2015
On 9 December 2015 at 13:21, Kyungwoo Lee via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> kyulee1 added a reviewer: enderby.
> kyulee1 updated this revision to Diff 42315.
> kyulee1 added a comment.
>
> Updated the changes -- no default value under MCTargetDesc.
> I'm not sure how to add a standalone test unless we want to extend an asm syntax like .pcrel and implement it using this.
> Since this API does not alter the default behavior, but I don't think testing is really necessary as long as build is successful.
Why do you need an extra argument? The expression being passed in can
be of the form
foo:
(....) - foo
which makes it pcrel.
Cheers,
Rafael
More information about the llvm-commits
mailing list