[test-suite] r255023 - [cmake] Add an option to suppress warnings in the test-suite
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 11:18:20 PST 2015
> On Dec 9, 2015, at 2:28 AM, James Molloy <James.Molloy at arm.com> wrote:
>
> Hi Matthias,
>
>> Maybe we shouldn't add -DNDEBUG unconditionally
>
> Without -DNDEBUG a load of the tests fail (to run, and some to compile), so I think -DNDEBUG should always be on. All I did was move it around in the file slightly.
Oh, I didn't know leaving out -DNDEBUG becomes a correctness problem in the test-suite, in that case we obviously have to unconditionally enable it.
- Matthias
More information about the llvm-commits
mailing list