[PATCH] D15377: [WebAssembly] Reintroduce ARGUMENT moving logic

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 06:41:51 PST 2015


jfb added a comment.

The order of the ARGUMENTs isn't changed by SelectionDAG?

This seems to fix the issue, but I'm not familiar enough with SelectionDAG to have an opinion about what it should be doing.


================
Comment at: lib/Target/WebAssembly/WebAssemblyArgumentMove.cpp:57
@@ +56,3 @@
+
+private:
+};
----------------
Dead.

================
Comment at: lib/Target/WebAssembly/WebAssemblyArgumentMove.cpp:82
@@ +81,3 @@
+        MI->getOpcode() != WebAssembly::ARGUMENT_F32 &&
+        MI->getOpcode() != WebAssembly::ARGUMENT_F64) {
+      InsertPt = MII;
----------------
Factor out `isArgument()`?


Repository:
  rL LLVM

http://reviews.llvm.org/D15377





More information about the llvm-commits mailing list