[PATCH] D15178: FunctionImporter: implement bulk function importing for efficiency

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

One small post-commit suggestion for a TODO.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:121
@@ +120,3 @@
+        if (!It.second) {
+          // This is a call to a function we already considered, skip.
+          continue;
----------------
We will never reconsider a function after initially deciding it isn't profitable to import. Currently the only profitability decision is based on the number of instructions, which won't change with importing. But perhaps we should add a TODO down where we have those checks to remove any callees from the CalledFunctions list if they fail a profitability check that may be affected by additional importing decisions.


http://reviews.llvm.org/D15178