[PATCH] D15320: CodeGen: Redo analyzePhysRegs() and computeRegisterLiveness()
hfinkel@anl.gov via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 9 05:50:22 PST 2015
hfinkel added a subscriber: hfinkel.
================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4446
@@ +4445,3 @@
+ if (!AXDead) {
+ // FIXME: If computeRegisterLiveness() reported LQR_Unknown and AX is
+ // dead even though we couldn't determine that, then we are reading an
----------------
This seems like an odd FIXME to keep now that we have a way to detect the situation. Why don't you detect the LQR_Unknown here and abort instead of doing something the verifier will complain about? Then we can have a FIXME that we really should be using some real analysis here instead of a local search.
Repository:
rL LLVM
http://reviews.llvm.org/D15320
More information about the llvm-commits
mailing list