[PATCH] D15364: [sancov] blacklist support.

[Ivan Krasin via llvm-commits]

krasin added a comment.

LGTM with nits


================
Comment at: test/tools/sancov/blacklist.test:2
@@ +1,3 @@
+REQUIRES: x86_64-linux
+RUN: sancov -obj %p/Inputs/test-linux_x86_64 -covered-functions -blacklist %p/Inputs/blacklist.txt %p/Inputs/test-linux_x86_64.sancov | FileCheck %s
+
----------------
Please, also add a test case for the default blacklist.

================
Comment at: tools/sancov/sancov.cc:88
@@ +87,3 @@
+
+static const char *const DefaultBlacklist = "fun:__sancov*";
+
----------------
Do we ever want to see __sancov* functions in the output? Right now, the logic is:

1. If we don't have a blacklist specified, use the default one and suppress __sancov* functions
2. If there's a blacklist specified, exclusively use it, forget about the default one.

It means that the following weird behavior is possible: a user creates a blacklist, puts a function or two there, runs the tool with the blacklist specified and gets *more* output than without --blacklist.

If would rather not have a default blacklist, or always have it. No strong opinion though.


http://reviews.llvm.org/D15364