[PATCH] D15257: AMDGPU/SI: Emit constant arrays in the .text section

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 16:05:29 PST 2015


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp:116
@@ +115,3 @@
+      // starts 4 bytes after the start of the add instruction, we end up
+      // with an offset that is 4 bytes to small.  This requres us to
+      // add 4 to the fixup value before applying it.
----------------
s/to/too/ and s/requres/requires/


http://reviews.llvm.org/D15257





More information about the llvm-commits mailing list