[PATCH] D15270: PassManagerInternal: remove unused parameters. NFC.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 15:48:04 PST 2015


On Tue, Dec 8, 2015 at 3:22 PM, Francis Visoiu Mistrih <thegameg1 at yahoo.com>
wrote:

>
> > On 8 déc. 2015, at 19:10, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > But we don't have that warning enabled, do we? (at least the Clang
> self-hosting build doesn't seem to ever trigger it, so I assume we don't
> have it enabled)
> Indeed, the warning is triggered only when building my project, which is
> using
> the LLVM API (trunk) on OS X.
>
> Since my project enabled these warnings, should LLVM not care about them,
> and let the users disable them manually?


There's some debate about how much our headers should be warning clean (of
which warnings?) for use in external projects with a higher/different
warning bar from the  one LLVM uses...

I don't have any clear answer/opinion on the matter.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/6a435325/attachment.html>


More information about the llvm-commits mailing list