[PATCH] D15352: [EarlyCSE] DSE of atomic unordered stores
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 14:40:10 PST 2015
reames added a comment.
In http://reviews.llvm.org/D15352#305309, @majnemer wrote:
> LGTM. You have a volatile-volatile test (test25). Does it make sense to add a simple-volatile test, unordered-volatile or a simple-unordered test?
simple-unordered is test22 (pre-existing)
The other two are probably undefined behaviour. Our specification is a bit unclear, but volatile (I believe) applies to a memory location, not an memory access. Thus, mixing volatile and non-volatile access to the same location is likely undefined behaviour.
http://reviews.llvm.org/D15352
More information about the llvm-commits
mailing list