[PATCH] D15351: Change hasInitializer() to call isStrongDefinitionForLinker() instead of !isWeakForLinker()

[Mehdi AMINI via llvm-commits]

joker.eph created this revision.
joker.eph added reviewers: pcc, rafael.
joker.eph added a subscriber: llvm-commits.

Available_externally global variable with initializer were considered "hasInitializer()",
while obviously it can't match the description:

    Whether the global variable has an initializer, and any changes made to the
    initializer will turn up in the final executable.

since modifying the initializer of an externally available variable does not make sense.

http://reviews.llvm.org/D15351

Files:
  include/llvm/IR/GlobalVariable.h
  test/Transforms/GlobalOpt/available_externally_global_ctors.ll

Index: test/Transforms/GlobalOpt/available_externally_global_ctors.ll
===================================================================
--- /dev/null
+++ test/Transforms/GlobalOpt/available_externally_global_ctors.ll
@@ -0,0 +1,22 @@
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx10.11.0"
+
+; RUN: opt -S -globalopt < %s | FileCheck %s
+
+; Verify that the initialization of the available_externally global is not eliminated
+; CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo_static_init, i8* null }]
+
+ at llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo_static_init, i8* null }]
+ at foo_external = available_externally global void ()* null
+
+define internal void @foo_static_init() {
+entry:
+  store void ()* @foo_impl, void ()** @foo_external
+  ret void
+}
+
+define internal void @foo_impl() {
+entry:
+  ret void
+}
+
Index: include/llvm/IR/GlobalVariable.h
===================================================================
--- include/llvm/IR/GlobalVariable.h
+++ include/llvm/IR/GlobalVariable.h
@@ -106,13 +106,8 @@
   /// any changes made to the initializer will turn up in the final executable.
   inline bool hasUniqueInitializer() const {
     return hasInitializer() &&
-      // It's not safe to modify initializers of global variables with weak
-      // linkage, because the linker might choose to discard the initializer and
-      // use the initializer from another instance of the global variable
-      // instead. It is wrong to modify the initializer of a global variable
-      // with *_odr linkage because then different instances of the global may
-      // have different initializers, breaking the One Definition Rule.
-      !isWeakForLinker() &&
+      // We need to be sure this is the definition that will actually be used
+      isStrongDefinitionForLinker() &&
       // It is not safe to modify initializers of global variables with the
       // external_initializer marker since the value may be changed at runtime
       // before C++ initializers are evaluated.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15351.42223.patch
Type: text/x-patch
Size: 2203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/694b1ea2/attachment.bin>