[PATCH] D15334: PC-relative support for EmitValue

[Andy Ayers via llvm-commits]

AndyAyers added a comment.

We should probably find an additional reviewer; can you check with code owners?

Also is there any way to test this?


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:511
@@ -511,1 +510,3 @@
+  void EmitValueImpl(const MCExpr *Value, unsigned Size, SMLoc Loc = SMLoc(),
+                     bool IsPCRelative = false) override {
     if (const MCSymbolRefExpr *SRE = dyn_cast_or_null<MCSymbolRefExpr>(Value))
----------------
Not sure if this is called out in the coding conventions or not, but since SMLoc wasn't given a default value before, it seems like neither SMLoc or IsPCRelative should be defaulted here.

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFStreamer.h:64
@@ -64,1 +63,3 @@
+  void EmitValueImpl(const MCExpr *Value, unsigned Size, SMLoc Loc,
+                     bool IsPCRelative = false) override;
 
----------------
Ditto here


http://reviews.llvm.org/D15334