[PATCH] D15330: Fix cycle in selection DAG introduced by extractelement legalization

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 10:56:47 PST 2015


ab added a comment.

The fix seems safe to me, though I'm a little worried about hasPredecessor().


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1483
@@ +1482,3 @@
+      // we will make the index dependent on the load).
+      if (Idx.getNode()->hasPredecessor(ST))
+        continue;
----------------
How about using hasPredecessorHelper?


http://reviews.llvm.org/D15330





More information about the llvm-commits mailing list